-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Clean up obsolete APIs in MVC #28337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for submitting this for API review. This will be reviewed by @dotnet/aspnet-api-review at the next meeting of the ASP.NET Core API Review group. Please ensure you take a look at the API review process documentation and ensure that:
|
src/Mvc/Mvc.Core/src/Infrastructure/PhysicalFileResultExecutor.cs
Outdated
Show resolved
Hide resolved
@dotnet/aspnet-api-review This is good for review. I've removed references to |
2070b3c
to
6c1d1ec
Compare
6c1d1ec
to
0c18367
Compare
Hello @pranavkm! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Part of #27529.
Summary of Changes
MVCOptions
was removed since that will eventually trigger a null-ref in the code.Remove GetFileStream API inPhysicalFileResultExecutor
andVirtualFileResultExecutor
because codepath is no-longer invoked.AllowShortCircuitingValidationWhenNoValidatorsArePresent
in ValidationVisitor because value no-ops and has been obsolete since 3.0.RemoveRazorViewAttribute
andRazorPageAttribute
and instances of use since they are deprecated in favor of newer APIs.ViewComponentResultExecutor
which set a nullWriterFactory
since the value was overridden anyways.CompatabilityVersion
type.