Skip to content

Add Testing projects to Components.slnf #27403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2020
Merged

Add Testing projects to Components.slnf #27403

merged 1 commit into from
Nov 2, 2020

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Oct 31, 2020

  • specifically Microsoft.AspNetCore.Analyzer.Testing and Microsoft.AspNetCore.Testing
    • Microsoft.AspNetCore.Analyzer.Testing was also not present in AspNetCore.sln

nits:

  • remove old projects from Components.slnf
    • no Microsoft.AspNetCore.NodeServices.csproj anymore
    • no Microsoft.AspNetCore.SpaServices.csproj anymore
  • VS reordered Components.slnf for some reason

@dougbu
Add Testing projects to Components.slnf
f68db2a 
- specifically Microsoft.AspNetCore.Analyzer.Testing and Microsoft.AspNetCore.Testing
  - Microsoft.AspNetCore.Analyzer.Testing was also not present in AspNetCore.sln

nits:
- remove old projects from Components.slnf
  - no Microsoft.AspNetCore.NodeServices.csproj anymore
  - no Microsoft.AspNetCore.SpaServices.csproj anymore
- VS reordered Components.slnf for some reason
@dougbu dougbu requested review from pranavkm and a team October 31, 2020 04:53
@dougbu dougbu requested review from SteveSandersonMS and a team as code owners October 31, 2020 04:53
@dougbu dougbu added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 31, 2020
@dougbu dougbu merged commit 64c248c into master Nov 2, 2020
@dougbu dougbu deleted the dougbu/more.slnf branch November 2, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@pranavkm pranavkm Awaiting requested review from pranavkm

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dougbu @wtgodbe