Switch to Windows.10.Arm64v8.Open Helix queue #27320

dougbu · 2020-10-29T02:05:28Z

this may avoid problems with empty $env:Path values

dougbu · 2020-10-29T02:06:25Z

Not sure this is going to work but @ilyas1974 was hopeful. See aspnetcore-helix-matrix run https://dev.azure.com/dnceng/public/_build/results?buildId=869710 for actual verification of the change.

eng/targets/Helix.Common.props

dougbu · 2020-10-29T03:26:05Z

This seems to take aspnetcore-helix-matrix in the right direction but doesn't get us to reliable tests on Windows ARM64. https://dev.azure.com/dnceng/public/_build/results?buildId=869710 shows

dotnet-watch tests fail on both Windows ARM64 and Debian 9 ARM64 machines
Libuv tests don't fare well on Windows ARM64 machines

Should the above be skipped on the relevant queues❔

Separately whatever happened with https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-aspnetcore-refs-heads-dougbu-alternate13f6996e221a4617ac/Microsoft.AspNetCore.Owin.Tests--net6.0/console.a52732bc.log?sv=2019-07-07 is just strange. https://helix.dot.net/api/jobs/13f6996e-221a-4617-ac28-7bcc4bc4b189/workitems/Microsoft.AspNetCore.Owin.Tests--net6.0?api-version=2019-06-17 doesn't add any information but does show the work item failed.

dougbu · 2020-10-29T04:01:53Z

https://dev.azure.com/dnceng/public/_build/results?buildId=869784 is new aspnetcore-helix-matrix build to watch

BrennanConroy · 2020-10-29T20:08:34Z

Rerun now that the SkipHelixArm property was used in halter's pr?

dougbu · 2020-10-29T20:26:25Z

/azp run

azure-pipelines · 2020-10-29T20:27:00Z

Azure Pipelines successfully started running 2 pipeline(s).

dougbu · 2020-10-29T20:28:40Z

Needed to rebase on master because the other pipeline won't pick up GitHub's merge commit

dougbu · 2020-10-29T20:31:00Z

Latest aspnetcore-helix-matrix build: https://dev.azure.com/dnceng/public/_build/results?buildId=870503

BrennanConroy · 2020-10-29T21:34:43Z

~~Odd, Libuv is still running~~

aspnetcore/src/Servers/Kestrel/test/Libuv.BindTests/Libuv.BindTests.csproj

Line 8 in 4e1cae0

<SkipHelixQueues>Windows.10.Arm64;Windows.10.Arm64.Open</SkipHelixQueues>

aspnetcore/src/Servers/Kestrel/test/Libuv.FunctionalTests/Libuv.FunctionalTests.csproj

Line 11 in a34dc1a

<SkipHelixQueues>Windows.10.Arm64;Windows.10.Arm64.Open</SkipHelixQueues>

BrennanConroy · 2020-10-29T21:42:08Z

This seems just as bad as the other ARM queue.

Hangs sometimes on dotnet-install

"InstallDotNet D:\h\w\9B4E08A5\w\B0F709D9\e\sdk8823\arm64 6.0.100-alpha.1.20523.3 arm64 '' $true '' '' $true"
GET https://dot.net/v1/dotnet-install.ps1
dotnet-install: Downloading link: https://dotnetcli.azureedge.net/dotnet/Sdk/6.0.100-alpha.1.20523.3/dotnet-sdk-6.0.100-alpha.1.20523.3-win-arm64.zip
dotnet-install: Extracting zip from https://dotnetcli.azureedge.net/dotnet/Sdk/6.0.100-alpha.1.20523.3/dotnet-sdk-6.0.100-alpha.1.20523.3-win-arm64.zip
dotnet-install: Adding to current process PATH: "D:\h\w\9B4E08A5\w\B0F709D9\e\sdk8823\arm64\". Note: This change will not be visible if PowerShell was run as a child process.
dotnet-install: Installation finished

"InstallDotNet D:\h\w\9B4E08A5\w\B0F709D9\e\sdk8823\arm64 6.0.0-alpha.1.20525.3 arm64 dotnet $true '' '' $true"
dotnet-install: Downloading link: https://dotnetcli.azureedge.net/dotnet/Runtime/6.0.0-alpha.1.20525.3/dotnet-runtime-6.0.0-alpha.1.20525.3-win-arm64.zip
dotnet-install: Extracting zip from https://dotnetcli.azureedge.net/dotnet/Runtime/6.0.0-alpha.1.20525.3/dotnet-runtime-6.0.0-alpha.1.20525.3-win-arm64.zip
dotnet-install: Adding to current process PATH: "D:\h\w\9B4E08A5\w\B0F709D9\e\sdk8823\arm64\". Note: This change will not be visible if PowerShell was run as a child process.
dotnet-install: Installation finished

- this may avoid problems with empty `$env:Path` values

- extend `$(CrossgenOutput)` changes to those jobs too

- also make sure internal queues are also skipped in updated attributes

dougbu · 2020-10-29T23:06:14Z

This seems just as bad as the other ARM queue.

You may be right but the problems still need to be resolved for whenever we get a working Windows ARM64 queue. Trying w/ the correct skips in place this time…

dougbu · 2020-10-30T05:08:17Z

Last run the only issues in the first attempt were problems downloading dotnet-install.* scripts or the SDK. That happened only in the non ARM64 work items. Reran failed jobs and got a clean result.

Suspect the CDN had a few hiccups…

dougbu · 2020-10-30T05:08:50Z

Marked ready for review

src/Servers/Kestrel/test/Libuv.BindTests/Libuv.BindTests.csproj

HaoK · 2020-10-30T05:41:49Z

src/Tools/dotnet-watch/test/AppWithDepsTests.cs

@@ -21,7 +21,7 @@ public AppWithDepsTests(ITestOutputHelper logger)

        [ConditionalFact]
        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23994")]
-        [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/23360", Queues = "Windows.10.Arm64;Windows.10.Arm64.Open;Debian.9.Arm64;Debian.9.Arm64.Open;(Debian.9.Arm64.Open)Ubuntu.1804.Armarch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:debian-9-helix-arm64v8-a12566d-20190807161036;(Debian.9.Arm64)Ubuntu.1804.Armarch@mcr.microsoft.com/dotnet-buildtools/prereqs:debian-9-helix-arm64v8-a12566d-20190807161036")]
+        [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/23360", Queues = "Windows.10.Arm64;Windows.10.Arm64.Open;Debian.9.Arm64;Debian.9.Arm64.Open;(Debian.9.Arm64.Open)Ubuntu.1804.Armarch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:debian-9-helix-arm64v8-a12566d-20190807161036;(Debian.9.Arm64)Ubuntu.1804.Armarch@mcr.microsoft.com/dotnet-buildtools/prereqs:debian-9-helix-arm64v8-a12566d-20190807161036;Windows.10.Arm64v8;Windows.10.Arm64v8.Open")]


related to the trait idea, this would be a case where we could use SkipOnHelix(traits = "arm"), as opposed to listing every arm queue manually :/

Maybe though we don't list all the ARM64 queues that often -- two or three times. Wouldn't recommend adding traits for the small noise reduction. (I also think of traits primarily in the context of command-line filtering e.g. quarantined or not.)

On the other hand, we might want to add a few static public strings for common queue combinations in the Testing project.

Either way, I'd rather make the larger change separately.

dougbu · 2020-10-30T19:30:03Z

@BrennanConroy @HaoK if comments are resolved from your perspective, please approve 😺

BrennanConroy

You have yet to acknowledge the <SkipHelixArm>true</SkipHelixArm> comment, or provide a valid reason not to use it.

dougbu · 2020-10-30T19:36:32Z

You have yet to acknowledge the <SkipHelixArm>true</SkipHelixArm> comment, or provide a valid reason not to use it.

It would be invalid to use that because the tests do run on Linux ARM64 machines just fine.

BrennanConroy

Non-windows ARM, of course!

dougbu requested review from halter73, Tratcher, HaoK and a team October 29, 2020 02:05

ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 29, 2020

dougbu commented Oct 29, 2020

View reviewed changes

eng/targets/Helix.Common.props Show resolved Hide resolved

dougbu force-pushed the dougbu/alternate.arm64 branch from a787416 to 402a18d Compare October 29, 2020 20:27

dougbu added 3 commits October 29, 2020 15:17

Switch to Windows.10.Arm64v8.Open Helix queue

4779bd0

- this may avoid problems with empty `$env:Path` values

Build shared framework for at least dotnet-watch tests on ARM64

44753a3

- extend `$(CrossgenOutput)` changes to those jobs too

Include Windows.10.Arm64v8.Open when skipping on Windows.10.Arm64.Open

b271457

- also make sure internal queues are also skipped in updated attributes

dougbu force-pushed the dougbu/alternate.arm64 branch from 402a18d to b271457 Compare October 29, 2020 23:03

dougbu marked this pull request as ready for review October 30, 2020 05:08

dougbu requested a review from jkotalik as a code owner October 30, 2020 05:08

BrennanConroy reviewed Oct 30, 2020

View reviewed changes

src/Servers/Kestrel/test/Libuv.BindTests/Libuv.BindTests.csproj Show resolved Hide resolved

HaoK reviewed Oct 30, 2020

View reviewed changes

BrennanConroy requested changes Oct 30, 2020

View reviewed changes

BrennanConroy approved these changes Oct 30, 2020

View reviewed changes

dougbu merged commit 540680a into master Oct 30, 2020

dougbu deleted the dougbu/alternate.arm64 branch October 30, 2020 19:47

Switch to Windows.10.Arm64v8.Open Helix queue #27320

Switch to Windows.10.Arm64v8.Open Helix queue #27320

Uh oh!

Conversation

dougbu commented Oct 29, 2020

Uh oh!

dougbu commented Oct 29, 2020

Uh oh!

Uh oh!

dougbu commented Oct 29, 2020

Uh oh!

dougbu commented Oct 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BrennanConroy commented Oct 29, 2020

Uh oh!

dougbu commented Oct 29, 2020

Uh oh!

azure-pipelines bot commented Oct 29, 2020

Uh oh!

dougbu commented Oct 29, 2020

Uh oh!

dougbu commented Oct 29, 2020

Uh oh!

BrennanConroy commented Oct 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BrennanConroy commented Oct 29, 2020

Uh oh!

dougbu commented Oct 29, 2020

Uh oh!

dougbu commented Oct 30, 2020

Uh oh!

dougbu commented Oct 30, 2020

Uh oh!

Uh oh!

HaoK Oct 30, 2020

Choose a reason for hiding this comment

Uh oh!

dougbu Oct 30, 2020

Choose a reason for hiding this comment

Uh oh!

dougbu commented Oct 30, 2020

Uh oh!

BrennanConroy left a comment

Choose a reason for hiding this comment

Uh oh!

dougbu commented Oct 30, 2020

Uh oh!

BrennanConroy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dougbu commented Oct 29, 2020 •

edited

Loading

BrennanConroy commented Oct 29, 2020 •

edited

Loading