Revert "Disconnect circuit on 'beforeunload' event" (#26297) #26894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add tests for failing disconnect scenarios * Remove beforeunload call and add public API * Add additional test case * Update src/Components/test/testassets/BasicTestApp/GracefulTermination.razor Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com> Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
ghost
added
the
captainsafia
added
the
Servicing-consider
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
mkArtakMSFT
added
Servicing-approved
|
This was approved by tactics / @SteveCarrollMSFT |
|
@dotnet/aspnet-blazor-eng this is approved. Please review so we can get this merged. |
pranavkm
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts a change that was introduced in #23224 to ensure that circuits are not disconnected when protocol-based links (e.g.
mailto:andtel:) are clicked or a download is programmatically triggered. This PR also:Customer Impact
This change was made in response to customer feedback that a recent bug fix broke important scenarios for users. Without this change, customer applications that use protocol-based links or programmatic downloads would break.
Regression
This is a regression from a previous patch release of 3.1.
Risk
The risk of this change is low: