Improve control stream handling with HTTP/3 #26644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jkotalik
commented
Oct 6, 2020
jkotalik
commented
- Don't create outbound encoder and decoder streams as they aren't required now in the spec
- Correctly check if inbound streams have been created to throw exceptions
- Don't allocate a huge amount for encoding.
ghost
added
the
gfoidl
reviewed
Oct 7, 2020
jkotalik
force-pushed
the
jkotalik/controlStreamHandling
branch
from
1c9ec42 to
f37541f
Compare
halter73
reviewed
Oct 8, 2020
| // An endpoint MUST allow its peer to create an encoder stream and a | ||
| // decoder stream even if the connection's settings prevent their use. | ||
|
|
||
| while (_isClosed == 0) |
There was a problem hiding this comment.
Nit: I think it's better to check result.IsCompleted than _isClosed to avoid spinning if the two ever get out -of-sync (even if they're synchronized today).
halter73
reviewed
Oct 8, 2020
|
|
||
| _haveReceivedSettingsFrame = true; | ||
| using var closedRegistration = _context.ConnectionContext.ConnectionClosed.Register(state => ((Http3ControlStream)state).OnStreamClosed(), this); | ||
| using var closedRegistration = _context.StreamContext.ConnectionClosed.Register(state => ((Http3ControlStream)state).OnStreamClosed(), this); |
There was a problem hiding this comment.
What's thee difference between OnStreamClosed() and OnInputOrOutputCompleted() supposed to be? I see that OnStreamClosed() calls Abort(ConnectionAbortedException ex) which currently no-ops.
|
Merging to my other branch (not to master); need something in this PR for a further refactoring. |
jkotalik
added a commit
that referenced
this pull request
Nov 17, 2020
jkotalik
added a commit
that referenced
this pull request
Dec 11, 2020
JamesNK
pushed a commit
that referenced
this pull request
Dec 20, 2020
jkotalik
added a commit
that referenced
this pull request
Jan 4, 2021
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.