Remove Blazor internal profiling infrastructure #24468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Could you do a quick check to see this fixes #24339? I was able to get this to throw by writing : |
pranavkm
approved these changes
Jul 31, 2020
Member
Author
|
@pranavkm Yes, it does appear to fix it. |
pranavkm
pushed a commit
that referenced
this pull request
Aug 5, 2020
* Put back InternalCalls * Removing .NET profiling calls * Remove JS side profiling
mkArtakMSFT
pushed a commit
that referenced
this pull request
Aug 5, 2020
HaoK
pushed a commit
that referenced
this pull request
Aug 7, 2020
* Put back InternalCalls * Removing .NET profiling calls * Remove JS side profiling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the internal profiling infrastructure previously added in #23510, because:
This PR also removes the JS-side profiling infrastructure, even though we don't have a similar replacement for it. I'm proposing to remove it because it's less useful (the JS-side code is already very tight, and the scenarios we're trying to optimize are now much heavier on the .NET side), it's not too hard to temporarily wire in a bit of timings capture code on an ad-hoc basis if you do want to measure something in JS, and it was quite a bit of extra JS code to be deploying into everyone's app which they couldn't even use.