[Backport] StopAsync resets state on inactive connection (#20083) #23962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BrennanConroy
added
the
Servicing-consider
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
jamshedd
added
Servicing-approved
|
Approved for 3.1.7. |
|
@BrennanConroy, my apologies, looks like both of us were trying to update the milestone from 3.1.x to 3.1.7 at the same time and I stamped over your changes. |
|
@BrennanConroy should I go ahead and merge? |
halter73
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
HubConnectioncould get into a permanently broken state ifStopAsyncwas called when the connection was already stopped in some cases. The fix is managing the state correctly soStopAsyncdoesn't break the connection.Customer Impact
Bug was reported by a customer in #18028.
Customers can run into difficulties when trying to write a reliable service that can restart the hub connection correctly.
The most reliable workaround is to entirely recreate the
HubConnectioninstead of reusing it. This can be difficult because of how customers' code is organized.Internal partner is also asking us to backport to fix issues they're seeing.
Regression?
Yes, new bug in 3.0+
Risk
Very low, simple fix with well understood problem and easily testable.