Move to latest NuGet.exe #23786
Move to latest NuGet.exe #23786
Conversation
dougbu
commented
Jul 8, 2020
dougbu
commented
- 5.3.0 -> 5.6.0
- should improve performance and may improve reliability
- 5.3.0 -> 5.6.0 - should improve performance and may improve reliability
ghost
added
the
|
What about other references to nuget in the repo? There's at least one other: |
| @@ -25,9 +25,8 @@ if (-not (Test-Path $NuGetDir)) { | |||
| } | |||
|
|
|||
| if (-not (Test-Path $NuGetExe)) { | |||
| # Using 5.3.0 to workaround https://github.com/NuGet/Home/issues/5016 | |||
There was a problem hiding this comment.
@rrelyea this bug doesn't appear relevant anymore, especially because we aren't using the more-performant 3.5.0 version. If that's correct, I'm wondering if is dotnet pack able to handle https://github.com/dotnet/aspnetcore/blob/master/src/Installers/Windows/SharedFramework/SharedFrameworkPackage.nuspec and https://github.com/dotnet/aspnetcore/blob/master/src/Installers/Windows/TargetingPack/TargetingPackPackage.nuspec as well as the properties we pass in below yet ❔ I don't see *.nuspecsupport in the help dotnet pack -? spits out but hope it's just undocumented 😄 or will be coming soon.
There was a problem hiding this comment.
Chatted offline w/ @rrelyea and it's likely we could create the two installer packages using a new *.csproj that runs after our *.wixproj.
Will file a separate issue about this work. It's a larger change and not something I'm going to tackle now. But, it would remove our need for NuGet.exe anywhere in this repo (outside a couple of Arcade post-build stages).
@rrelyea would changing that one negatively impact loading our tasks into |
|
And @rrelyea if I shouldn't be asking you NuGet questions anymore please add the right contact. |
|
it might be easier to have a quick teams call to chat through these several questions. call me sometime? |
|
Sounds good @rrelyea |
|
@rrelyea and I also discussed updating There should be no downside to moving to 5.6.0. @rrelyea also pointed out we don't need all of NuGet.Build.Tasks and could move to getting just NuGet.Packaging. Overall, that transitively brings in 5 packages instead of the current 12. I confirmed this looking at RepoTasks.dll and am going to try this narrowing out in the next iteration. |
- move to 5.6.0 version here too - reduce transitive dependencies; we don't need them all
|
/ping @dotnet/aspnet-build this is building successfully and just needs a review 😺 |
