Fix java pack on local builds #23237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
dougbu
approved these changes
Jun 22, 2020
| @@ -6,6 +6,6 @@ | |||
|
|
|||
| class Version { | |||
| public static String getDetailedVersion() { | |||
| return "99.99.99-dev"; | |||
| return "5.0.0-dev"; | |||
There was a problem hiding this comment.
Isn't this file automatically updated anyhow? I'm wondering because PR validation (where the version is "5.0.0-ci") and builds of release/5.0-preview* have been succeeding.
Put another way, does this file need to change?
There was a problem hiding this comment.
If we don't update the file then local builds will constantly show this file as changed which is annoying. We could ignore the file, but this seems fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version file will update every major/minor, but those aren't very often so it's fine.