Two minor perf tweaks in CORS and Localization middleware #23190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the newer overload for string.Split() that accepts a char instead of creating a char array.
Remove redundant bounds check for count of exactly 1 as that has already been checked to be true by the previous check.
ghost
added
the
pranavkm
reviewed
Jun 22, 2020
| @@ -60,9 +59,7 @@ public static string MakeCookieValue(RequestCulture requestCulture) | |||
| throw new ArgumentNullException(nameof(requestCulture)); | |||
| } | |||
|
|
|||
| var seperator = _cookieSeparator[0].ToString(); | |||
pranavkm
approved these changes
Jun 23, 2020
|
Thanks! |
amcasey
added
the
area-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
string.Split()that accepts acharinstead of creating achar[].