Skip to content

Disable Yarn warnings on CI builds for restore and Blazor WebAssembly projects #22703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

javiercn
Copy link
Member

@javiercn javiercn commented Jun 9, 2020

Fixes #22251 and #22240.

The approach is to disable the warnings when we run the command on the CI and leave them on Dev builds.

I tried to use CustomWarningRegularExpression but that is not available on ToolTask (only exec task) so this is the best we can do.

@javiercn javiercn force-pushed the javiercn/yarn-warnings-ci branch from 5d8efa2 to 7382222 Compare June 9, 2020 13:32
@Pilchie Pilchie added the area-blazor Includes: Blazor, Razor Components label Jun 9, 2020
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works but I think we should take a close look at the Yarn.MSBuild SDK. According to @mmitche it's part of the reason our builds are as slow as they are and a lot of the reason our binary logs are useless. The inability to suppress the specific warning we're seeing is another strike against it; I worry about missing other issues in the future.

@dougbu dougbu mentioned this pull request Jun 9, 2020
18 tasks
@javiercn
Copy link
Member Author

javiercn commented Jun 9, 2020

This works but I think we should take a close look at the Yarn.MSBuild SDK. According to @mmitche it's part of the reason our builds are as slow as they are and a lot of the reason our binary logs are useless. The inability to suppress the specific warning we're seeing is another strike against it; I worry about missing other issues in the future.

That's fine, can you file a separate issue for that and we can add that to the DoI agenda? Since it affects SignalR, Templates and Components among other things.

For what we are trying to accomplish here, this change should be enough in the mean time.

@javiercn javiercn merged commit a273560 into master Jun 9, 2020
@javiercn javiercn deleted the javiercn/yarn-warnings-ci branch June 9, 2020 16:53
@dougbu
Copy link
Contributor

dougbu commented Jun 9, 2020

this change should be enough in the mean time.

Agreed

@dougbu
Copy link
Contributor

dougbu commented Jun 9, 2020

Filed #22723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix warning "Waiting for the other yarn instance to finish"
3 participants