Skip to content

Get MSBuild performance summary #21487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented May 5, 2020

No description provided.

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 5, 2020
@JunTaoLuo
Copy link
Contributor

😞 but :shipit:

@wtgodbe
Copy link
Member

wtgodbe commented May 5, 2020

Won't the changes to eng/common/tools.ps1 be overwritten by the next update from Arcade?

@dougbu
Copy link
Contributor Author

dougbu commented May 5, 2020

Won't the changes to eng/common/tools.ps1 be overwritten by the next update from Arcade?

Yes. That's why we need to change Arcade if we're going to stop using binary logs.

BTW this PR is not something I intend to merge. The first commit isn't something we want or need in general. It's just useful as we try out ways to improve build performance e.g. @mmitche's investigations and mine.

@dougbu dougbu force-pushed the dougbu/performance.summary branch from c8652df to d7bf406 Compare May 15, 2020 23:48
@dougbu dougbu force-pushed the dougbu/performance.summary branch 2 times, most recently from 44c4d89 to 5fe8bfc Compare June 3, 2020 20:20
@dougbu dougbu force-pushed the dougbu/performance.summary branch from 5fe8bfc to 82bdc4a Compare August 4, 2020 01:11
@dougbu
Copy link
Contributor Author

dougbu commented Aug 4, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Base automatically changed from master to main January 22, 2021 01:32
@dougbu dougbu force-pushed the dougbu/performance.summary branch 3 times, most recently from eb77c4d to 1b3fd49 Compare January 30, 2021 22:32
dougbu added a commit that referenced this pull request Feb 2, 2021
- how did Linux builds ever work?
  - case difference between these lines and global `$(Configuration)` value is **really** old
  - same for case in src/Components/Web.JS/src/webpack.config.js versus `$(Configuration)`

I'm not sure this is the right fix when building `Debug`
- will overwrite the checked-in dist/Debug files
- should the project no-op in that configuration?

Error seen in #21487 w/o this:
``` text
error MSB3954: Failed to compute hash for file '/datadisks/disk1/workspace/_work/1/s/src/Components/Web.JS/dist/Release/blazor.webassembly.js' because it does not exist or is inaccessible.
```
@dougbu dougbu force-pushed the dougbu/performance.summary branch from 1b3fd49 to f73d19b Compare February 2, 2021 02:26
dougbu added a commit that referenced this pull request Feb 3, 2021
- how did Linux builds ever work?
  - case difference between these lines and global `$(Configuration)` value is **really** old
  - same for case in src/Components/Web.JS/src/webpack.config.js versus `$(Configuration)`

I'm not sure this is the right fix when building `Debug`
- will overwrite the checked-in dist/Debug files
- should the project no-op in that configuration?

Error seen in #21487 w/o this:
``` text
error MSB3954: Failed to compute hash for file '/datadisks/disk1/workspace/_work/1/s/src/Components/Web.JS/dist/Release/blazor.webassembly.js' because it does not exist or is inaccessible.
```
@dougbu dougbu force-pushed the dougbu/performance.summary branch from f73d19b to 0a0e87c Compare February 3, 2021 05:15
@dougbu dougbu force-pushed the dougbu/performance.summary branch from 0a0e87c to 195e3c1 Compare February 18, 2021 01:28
- run those jobs 10 times
- do not dupe the `@(ProjectReferenceProvider)` item group
@dougbu dougbu force-pushed the dougbu/performance.summary branch from 076d003 to d901966 Compare February 24, 2021 05:25
@dougbu dougbu closed this Mar 8, 2021
@dougbu dougbu deleted the dougbu/performance.summary branch March 8, 2021 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants