-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[Helix] Don't fail fast on ef tool install issues (may be already installed) #20958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Unrelated to this PR, so interesting @dougbu looks like the skip-ci only affects the aspnetcore-pr-validation-temp pipeline https://dev.azure.com/dnceng/public/_build?definitionId=279 |
Do we understand if this does the right thing if the wrong version of the |
Seem like we should install or update. |
So my impression is that you can install multiple versions of the tool, and the failure we were running into was that the version we were trying to install was already installed (maybe the SDK caught up to our runtime version?) |
|
We should verify that installing multiple versions actually works the way we expect. @wli3 - do you know about this? |
Does it need to be installed globally? Seems like we should be installing it into a subfolder and using that instead no? |
It should be installed in a local folder, I believe the DOTNET_CLI_HOME variable controls that. But it looks like we are no longer setting that after switching to the C# runner. |
Okay I can open a new PR on monday that switches to installing the tool non globally |
The bug here is not setting |
This should be part of the helix package #20876 |
No description provided.