Fix #19991 Made TestHost fail when Response Flush is called with AllowSynchronossIO being dissabled #20059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sIO being dissabled.
ghost
added
the
This was referenced Mar 23, 2020
Tratcher
requested changes
Mar 24, 2020
There was a problem hiding this comment.
Looks like this caused several failures in other TestServer tests. There are also failures in ResponseCompression. Please take a look.
https://dev.azure.com/dnceng/public/_build/results?buildId=568952&view=ms.vss-test-web.build-test-results-tab&runId=17857014&resultId=100431&paneView=debug
|
I fixed the tests, but it seems there is some instability failing the build? |
Tratcher
reviewed
Mar 25, 2020
src/Middleware/ResponseCompression/test/ResponseCompressionMiddlewareTest.cs
Outdated
Show resolved
Hide resolved
…hronousIO enabled.
Tratcher
approved these changes
Mar 25, 2020
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestHost behaves differently than Kestrel, when Response's synchronous Flush is called. Kestrel fails with an InvalidOperationException, while TestHost works properly. This change should make the two behave the same way.
If any tests fail because of this change, it means the same code would fail running in Kestrel.
Addresses #19991