Test run of excluding Microsoft.Aspnetcore.testing ref assembly #18720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, looks like this works. We can just re-do dotnet/extensions#2817 and insert this change for 3.1.3 |
JunTaoLuo
reviewed
Jan 31, 2020
| @@ -293,7 +293,7 @@ | |||
| <ItemGroup> | |||
| <ReferencePath> | |||
| <ReferenceAssembly | |||
| Condition=" '%(ReferencePath.ReferenceAssembly)' == '' AND Exists('$(MicrosoftInternalExtensionsRefsPath)%(FileName).dll') ">$(MicrosoftInternalExtensionsRefsPath)%(FileName).dll</ReferenceAssembly> | |||
| Condition=" '%(ReferencePath.ReferenceAssembly)' == '' AND Exists('$(MicrosoftInternalExtensionsRefsPath)%(FileName).dll') AND '%(FileName)' != 'Microsoft.AspNetCore.Testing' ">$(MicrosoftInternalExtensionsRefsPath)%(FileName).dll</ReferenceAssembly> | |||
There was a problem hiding this comment.
This is really the only change that we'd want right? The rest is to test this change?
JunTaoLuo
approved these changes
Jan 31, 2020
Pilchie
added
the
area-infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof-of-concept of excluding the Microsoft.AspNetCore.Testing ref assembly from the bad 3.1.0 extensions ref pack. The versions files have been downgraded to consume the version of extensions where we deleted that ref assembly from the project.
CC @dougbu @JunTaoLuo