Skip to content

Cleanup processes started by UseReactDevelopmentServer and UseAngularCliServer #17883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2020
Merged

Cleanup processes started by UseReactDevelopmentServer and UseAngularCliServer #17883

merged 1 commit into from
Jan 30, 2020

Conversation

AndriySvyryd
Copy link
Member

Fixes #11597

@AndriySvyryd AndriySvyryd force-pushed the Issue11597 branch 4 times, most recently from c99927c to 6696063 Compare December 15, 2019 07:38
ryanbrandenburg
ryanbrandenburg suggested changes Dec 26, 2019
View reviewed changes
Copy link
Contributor

@ryanbrandenburg ryanbrandenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell the actual code change here is good, but I believe the tests as-is are likely to be flaky. Should be in a much better place once that's resolved.

...dleware/SpaServices.Extensions/test/Microsoft.AspNetCore.SpaServices.Extensions.Tests.csproj
@@ -14,4 +14,10 @@
<Content Include="js\**\*" />
</ItemGroup>

<ItemGroup>
<None Update="package.json">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the behavior we get without this line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm exits immediately

src/Middleware/SpaServices.Extensions/test/SpaServicesExtensionsTests.cs
}

private string GetCommand()
=> RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? "waitWindows" : "wait";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are we trying to accomplish with these? Get command is a bit nondescript. What are the criteria that these commands have to meet in order to work in this instance?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command must run indefinitely until the process is killed

@AndriySvyryd AndriySvyryd force-pushed the Issue11597 branch 4 times, most recently from e88ee60 to 33997d5 Compare January 11, 2020 20:19
@analogrelay analogrelay added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates and removed area-middleware labels Jan 24, 2020
@mkArtakMSFT
Copy link
Contributor

@ryanbrandenburg are we waiting for more changes from @AndriySvyryd here?

ryanbrandenburg
ryanbrandenburg approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@ryanbrandenburg ryanbrandenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I really like the diagnostic listener pattern, I might end up stealing that in some spots.

One small comment inclusion then I think we can call this good.

@AndriySvyryd AndriySvyryd merged commit db3d23b into master Jan 30, 2020
@AndriySvyryd AndriySvyryd deleted the Issue11597 branch January 30, 2020 02:31
@leandroaraujosouza
Copy link

Hi @AndriySvyryd can you tell when this is gonna be published with the SDK ?

@AndriySvyryd
Copy link
Member Author

Nightly builds should already have this. Preview1 will be out soon*. The RTM version will be out in November.

@Tratcher Tratcher mentioned this pull request Aug 9, 2021
Merged
@JSLGeeganage
Copy link

Hi @AndriySvyryd, the related issue still can produce in dot net version 5.0.100. If I start debug using (not using IIS) Visual Studio (16.8.2), node process still open even I stopped the debug.

But the crt+c will kill all the node process when you use dotnet run command using developer user command prompt.

@ghost
Copy link

ghost commented Aug 11, 2021

Hi @JSLGeeganage. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanbrandenburg ryanbrandenburg ryanbrandenburg approved these changes

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS

@analogrelay analogrelay Awaiting requested review from analogrelay

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UseReactDevelopmentServer with UseSpa keeps console open.
7 participants
@AndriySvyryd @mkArtakMSFT @leandroaraujosouza @JSLGeeganage @SteveSandersonMS @ryanbrandenburg @analogrelay