[release/3.1] Download runtime from suffixed location in dotnetcli blob storage #17592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmitche
approved these changes
Dec 4, 2019
mmitche
changed the title
JunTaoLuo
approved these changes
Dec 4, 2019
dougbu
approved these changes
Dec 5, 2019
|
I'll merge this after the internal mirror conflict gets cleaned up |
|
@wtgodbe Good to merge? |
…etcore into NetCoreAppInternal31
|
Will merge this after CI passes again |
Pilchie
added
the
area-infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where, when we depend on a stable core-setup, we try to download the runtime from a non-suffixed location in the
dotnetcliblob storage account. This location will only exist when a build has been placed there manually, which leads to a possible mismatch between the build we bundle, and the build we actually want to ship (e.g. if we spin multiple stable builds, and the first is still in the blob storage location when we spin the 2nd AspNetCore build). Instead we should use the explicit suffixed location so that we know we're consuming the correct build.CC @dougbu @JunTaoLuo @mmitche @leecow @nguerrera
Manual port of #17593, since the 3.0 -> 3.1 mirror is currently off, and we probably want this for 3.1.1