Skip to content

Use M.NC.App RefPack version for dotnet targeting pack dependency version #16832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2019

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Nov 5, 2019

We should keep the dependency on the dotnet-targeting-pack in line with our (pinned) dependency on `Microsoft.NetCore.App.Ref. This fixes the following error in Core-SDK:

EXEC : error : Failed dependencies: [/home/vsts/work/1/s/src/redist/redist.csproj]
##[error]EXEC(0,0): error : Failed dependencies:
dotnet-targeting-pack-3.0 >= 3.0.1 is needed by aspnetcore-targeting-pack-3.0-3.0.1-1.x86_64

/home/vsts/work/1/s/src/redist/targets/GenerateRPMs.targets(295,5): error MSB3073: The command "sudo rpm -iv /home/vsts/work/1/s/artifacts/obj/redist/Release/downloads/aspnetcore-targeting-pack-3.0.1.rpm" exited with code 1. [/home/vsts/work/1/s/src/redist/redist.csproj]

##[error]src/redist/targets/GenerateRPMs.targets(295,5): error MSB3073: The command "sudo rpm -iv /home/vsts/work/1/s/artifacts/obj/redist/Release/downloads/aspnetcore-targeting-pack-3.0.1.rpm" exited with code 1.

CC @dougbu @JunTaoLuo @nguerrera @mmitche

@mmitche mmitche merged commit 22dedcb into release/3.0 Nov 5, 2019
@mmitche mmitche deleted the RefPack branch November 5, 2019 00:09
@analogrelay analogrelay added this to the 3.0.1 milestone Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants