-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Helix] Move helix arm run to ci #13939
Conversation
@@ -487,6 +487,26 @@ jobs: | |||
path: artifacts/TestResults/ | |||
publishOnError: true | |||
|
|||
# Helix ARM64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the past week or so I haven't actually seen the arm tests fail while tweaking the helix stuff. I just took a brief manual look at the arm runs for the past few days and I haven't seen any real failures so I'm optimistic. Maybe we can try turning it on over the weekend and I can monitor things while its lower traffic, its easy to back out anyways if ends up blocking PRs.
Now that the mac queue is gone, and the log typo has been fixed I've actually seen consistent green helix checks since yesterday on my PRs!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try this and see how it goes. We should also send a mail to the team describing the change, and who to talk to if there are issues.
@@ -487,6 +487,26 @@ jobs: | |||
path: artifacts/TestResults/ | |||
publishOnError: true | |||
|
|||
# Helix ARM64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try this and see how it goes. We should also send a mail to the team describing the change, and who to talk to if there are issues.
Wish me luck, I told people to contact me directly if things blow up |
This should make helix passing on arm queues required for PR checks