Skip to content

Remove last couple of (test-only) System.Data.SqlClient dependencies #13426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2019

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Aug 25, 2019

No description provided.

@dougbu dougbu marked this pull request as ready for review August 25, 2019 22:35
@dougbu dougbu requested review from analogrelay, Tratcher and a team as code owners August 25, 2019 22:35
@dougbu dougbu removed the request for review from analogrelay August 25, 2019 22:36
Copy link
Member

@Pilchie Pilchie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 As long as helix failures aren't related.

@dougbu dougbu added tell-mode Indicates a PR which is being merged during tell-mode Test labels Aug 26, 2019
@dougbu
Copy link
Contributor Author

dougbu commented Aug 26, 2019

No, Helix failures are about usual flakiness and recently-consistent issues on Debian.9.Arm64.Open.

Which reminds me: @MattGal is there a known issue with the (Debian.9.Arm64.Open)Ubuntu.1604.Arm64.Docker.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:debian-9-helix-arm64v8-a12566d-20190807161036 docker image or Helix on that image?

@dougbu dougbu merged commit b496781 into release/3.0 Aug 26, 2019
@ghost ghost deleted the dougbu/remove.SqlClient branch August 26, 2019 16:04
@MattGal
Copy link
Member

MattGal commented Aug 26, 2019

@dougbu we had some issues recently with disk space on some newly set up machines. I'm taking a look.

@MattGal
Copy link
Member

MattGal commented Aug 26, 2019

@dougbu this was https://github.com/dotnet/core-eng/issues/7557 from what you showed me and all three of the offending machines are offline now. Please ping me ASAP if you see this problem continuing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants