HPACK circular overflow #12190 #12782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good and OK with me for ask-mode. Apply the label when review approvals are received. |
Tratcher
added
the
ask-mode
|
Tactics approved |
jkotalik
approved these changes
Aug 1, 2019
ghost
deleted the
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@anurse 3.0 candidate
Description
When the client tries to intern more than 127 entries in the dynamic header table it reaches the end of the circular buffer and fails to properly wrap.
Customer Impact
Multiple external reports, depends on client input, hard to diagnose, and with no mitigation but to disable HTTP/2.
#12190
#12045
Regression? No
Risk
Low. Once we understood the repro the fix was simple and easy to test.
@geoffkizer This bug also exists in corefx:
https://github.com/dotnet/corefx/blob/06d215d9fe6fff08f81add5ed341641f668075c0/src/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HPack/DynamicTable.cs#L37