Skip to content

Change unsupported culture log level #12153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2019
Merged

Change unsupported culture log level #12153

merged 2 commits into from
Jul 24, 2019

Conversation

hishamco
Copy link
Member

Fixes #4504

@hishamco
Copy link
Member Author

Oops, seems origin/master little bit old, I will fetch upstream and fix the conflicts soon ..

@analogrelay analogrelay added area-middleware area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates and removed area-middleware labels Jul 15, 2019
@mkArtakMSFT
Copy link
Contributor

Thanks @hishamco.
@ryanbrandenburg waiting for your review.

@ryanbrandenburg
Copy link
Contributor

I've approved, but those tests that are failing are for real. There's a test somewhere that checks what level this log is, you need to adjust the expectations there before you'll get a green build and I can merge this.

@mkArtakMSFT
Copy link
Contributor

Thanks @ryanbrandenburg.
@hishamco hope you can fix the tests too, so we can get this merged.

@hishamco
Copy link
Member Author

hishamco commented Jul 23, 2019 •
edited
Loading

I will check them, pardon me I am not able to open the solution in VS 2019, I'm still blocked by this issue dotnet/extensions#1931

@hishamco
Copy link
Member Author

:shipit:

@mkArtakMSFT mkArtakMSFT added the tell-mode Indicates a PR which is being merged during tell-mode label Jul 24, 2019
@mkArtakMSFT mkArtakMSFT merged commit 28678ee into dotnet:master Jul 24, 2019
@mkArtakMSFT mkArtakMSFT modified the milestone: 3.0.0 Jul 24, 2019
@hishamco hishamco deleted the fixes#4504 branch July 24, 2019 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanbrandenburg ryanbrandenburg ryanbrandenburg approved these changes

@mkArtakMSFT mkArtakMSFT mkArtakMSFT approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RequestLocalizationMiddleware logs at warning
4 participants
@hishamco @mkArtakMSFT @ryanbrandenburg @analogrelay