Skip to content

[Helix] run on arm queues #11422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 44 commits into from
Jun 30, 2019
Merged

[Helix] run on arm queues #11422

merged 44 commits into from
Jun 30, 2019

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Jun 20, 2019

Cleaned up for rebase version of #8844

@HaoK HaoK added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 20, 2019
HaoK
HaoK commented Jun 26, 2019
View reviewed changes
dougbu
dougbu reviewed Jun 26, 2019
View reviewed changes
@HaoK
Copy link
Member Author

HaoK commented Jun 27, 2019

Finally looks like helix tests are passing on arm64, marking as ready for review

@HaoK HaoK marked this pull request as ready for review June 27, 2019 00:38
@HaoK HaoK requested review from analogrelay, Tratcher and a team as code owners June 27, 2019 00:38
dougbu
dougbu approved these changes Jun 29, 2019
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good but Helix run did not pass. Once it does, feel free to merge

eng/targets/Helix.Common.props
<!-- arm64 queues -->
<HelixAvailableTargetQueue Include="(Debian.9.Arm64.Open)Ubuntu.1604.Arm64.Docker.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:debian-9-helix-arm64v8-0a0ebdd-20190312215438" Platform="Linux" />

<!-- Need to resolve permission issues on this docker queue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an issue tracking this TODO?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#11718

@HaoK
Copy link
Member Author

HaoK commented Jun 29, 2019

@dougbu I see one test failure that looks like a pass on rerun, https://mc.dot.net/#/user/aspnetcore/pr~2Faspnet~2Faspnetcore/ci/20190626.58.arm64.1 shows all green

https://mc.dot.net/#/user/aspnetcore/pr~2Faspnet~2Faspnetcore/ci/20190626.58.arm64.1/workItem/dotnet-user-secrets.Tests~2Fnetcoreapp3.0/wilogs took a second try

@dougbu
Copy link
Contributor

dougbu commented Jun 29, 2019

Microsoft.Extensions.SecretManager.Tools.Tests.Microsoft.Extensions.SecretManager.Tools.Tests.SecretManagerTests.SetSecret_Update_Existing_Secret shows as failing in https://dev.azure.com/dnceng/public/_build/results?buildId=240998&view=ms.vss-test-web.build-test-results-tab despite what https://mc.dot.net/#/user/aspnetcore/pr~2Faspnet~2Faspnetcore/ci/20190626.58.arm64.1 indicates

@HaoK HaoK merged commit 6dc65b1 into master Jun 30, 2019
@HaoK
Copy link
Member Author

HaoK commented Jun 30, 2019

All green this time, merging

@ghost ghost deleted the helix-arm2 branch June 30, 2019 08:05
@HaoK HaoK mentioned this pull request Jun 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HaoK @dougbu