-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always include ANCM in build output #11198
Always include ANCM in build output #11198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is a fix that we need in order to build our 2.2 patch. @anurse what kind of approval process is needed for this change?
👍 . Make sure |
Approved for 2.2.6 |
I'm going to merge this one since we are running into build hangs on 2.2 right now and it's unlikely that the tests will pass. The linux failure is unrelated. |
Note, this is purely a build only change. I'm currently working on verifying this works with separate branches on aspnetci.
Impact
After we stopped pushing to MyGet, ANCM transfer packages have stopped being uploaded. Builds are now failing with an error saying ANCM could not be found as an artifact dependency as well as the latest version of ANCM being 2.2.2 on myget. This change makes it so ANCM always builds, regardless of if there was a change to ANCM or not.
The reason this is fine is:
Risk
Very low risk. We are rebuilding ANCM every patch version, which will update dll/msi versions. However, the source code being used is the same.