Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try windows-2019 AzDO (hosted) queues #11129

Closed
wants to merge 1 commit into from
Closed

Try windows-2019 AzDO (hosted) queues #11129

wants to merge 1 commit into from

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Jun 12, 2019

  • aspnet/AspNetCore-Internal#2538

PR currently includes an extra commit for debugging in case PR validation fails

@dougbu
Copy link
Member Author

dougbu commented Jun 12, 2019

Trial official build: https://dnceng.visualstudio.com/internal/_build/results?buildId=221506

@Eilon Eilon added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 12, 2019
@dougbu
Copy link
Member Author

dougbu commented Jun 12, 2019

Trial official build succeeded but PR checks failed due to hanging builds. Retrying PR validation…

@dougbu dougbu marked this pull request as ready for review June 12, 2019 17:01
@dougbu dougbu requested a review from a team as a code owner June 12, 2019 17:01
@dougbu dougbu force-pushed the dougbu/hosted.2019.2538 branch from 3927a32 to c4c7747 Compare June 12, 2019 18:32
@dougbu
Copy link
Member Author

dougbu commented Jun 12, 2019

🆙📅 to remove debugging information from CodeCheck.ps1. VS BuildTools edition on hosted machines is sufficient for our builds and information is no longer needed.

@dougbu
Copy link
Member Author

dougbu commented Jun 13, 2019

Still waiting for the build to succeed. Now trying attempt #3.

@jkotalik @JunTaoLuo @natemcmaster are the following common warnings when building the site extensions? Got this from attempt #2's x64 build. The Windows test jobs showed similar warnings and then errors about inaccessible files.

CSC : warning CS2008: No source files specified. [D:\a\1\s\src\SiteExtensions\LoggingBranch\LoggingBranch.csproj]
D:\a\1\s\.dotnet\sdk\3.0.100-preview5-011568\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.ComposeStore.targets(347,5): warning MSB3026: Could not copy "D:\a\1\s\.nuget\packages\runtime.win-x64.microsoft.netcore.app\3.0.0-preview7-27810-02\runtimes\win-x64\native\mscorrc.debug.dll" to "D:\a\1\s\artifacts\obj\LoggingBranch\Release\net461\win-x64\se\rs\win-x64\x64\netcoreapp3.0\mscorrc.debug.dll". Beginning retry 1 in 1000ms. The process cannot access the file 'D:\a\1\s\artifacts\obj\LoggingBranch\Release\net461\win-x64\se\rs\win-x64\x64\netcoreapp3.0\mscorrc.debug.dll' because it is being used by another process.  [D:\a\1\s\artifacts\obj\LoggingBranch\Release\net461\win-x64\se\rs.csproj]

@natemcmaster
Copy link
Contributor

This is one of the problems with the way site extension build code currently works. I believe it stems from bugs in the ‘dotnet store’ command, which @nguerrera is working on fixing for 3.0. dotnet/sdk#1211, dotnet/sdk#1072

@dougbu
Copy link
Member Author

dougbu commented Jun 13, 2019

@natemcmaster does that explain the hanging builds as well as the warnings?

The three Windows jobs look stuck after succeeding again in this last attempt. Since we've seen this behaviour in many other PRs lately, I'm leaning toward merging now. Thoughts?

@natemcmaster
Copy link
Contributor

I don't think that explains the hang. I think the hanging is a regression in Azure Pipelines' handling of background processes, but John is looking into it.

@dougbu dougbu force-pushed the dougbu/hosted.2019.2538 branch 3 times, most recently from e378659 to 0bb965d Compare June 14, 2019 19:48
@dougbu
Use windows-2019 AzDO (hosted) queues
5931c3c 
- dotnet/aspnetcore-internal#2538
- stick with BYOC queues for internal builds

nit: remove unused `poolName` parameter
@dougbu dougbu force-pushed the dougbu/hosted.2019.2538 branch from 0bb965d to 5931c3c Compare June 15, 2019 03:46
@dougbu
Copy link
Member Author

dougbu commented Jun 15, 2019

Since #11230 this PR can't work because tar is not available. The agents in this queue must be older than Windows 10, version 1803. Try again in a couple of weeks…

@dougbu dougbu closed this Jun 15, 2019
@dougbu dougbu deleted the dougbu/hosted.2019.2538 branch June 15, 2019 06:16
@dougbu dougbu added blocked The work on this issue is blocked due to some dependency and removed blocked The work on this issue is blocked due to some dependency labels Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemcmaster natemcmaster natemcmaster approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dougbu @natemcmaster @Eilon