Guarantee that ANCM package dlls are used for back compat tests #10858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemcmaster
reviewed
Jun 5, 2019
src/Servers/IIS/IIS/test/IIS.NewHandler.FunctionalTests/IIS.NewHandler.FunctionalTests.csproj
Outdated
Show resolved
Hide resolved
Sounds reasonable to me. |
BrennanConroy
approved these changes
Jun 5, 2019
|
This comment was made automatically. If there is a problem contact aspnetcore-build@microsoft.com. I've triaged the above build. I've created/commented on the following issue(s) |
ghost
deleted the
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/aspnet/AspNetCore-Internal/issues/2620. Also renames a few projects to avoid confusion.
TL;DR we have tests that use an older version of the AspNetCoreModule, which are copied to a bin folder eventually. These references can race with build outputs from the project build itself. We had a check to look a the full path to the dll and remove all ANCM references from the project build. This broke with dc90e11, which caused flakiness with copying, causing weird test failures like shown above.
@natemcmaster I'm not a fan at all of the solution I came up with. Fundamentally, this all stems from this specific test group referencing M.A.Servers.IntegrationTesting.IIS. Maybe I can conditionally depend on the native components in this specific project instead, such that this race never happens.