Some projects need to add <InterceptorsNamespaces> with the latest aspnet builds

[sebastienros]

Example in Orchard:

/tmp/benchmarks-agent/benchmarks-server-1/iaulnbd3.afr/src/OrchardCore.Modules/OrchardCore.OpenId/obj/Release/net10.0/Microsoft.AspNetCore.Http.ValidationsGenerator/Microsoft.AspNetCore.Http.ValidationsGenerator.ValidationsGenerator/ValidatableInfoResolver.g.cs(79,10): error CS9137: The 'interceptors' feature is not enabled in this namespace. Add '<InterceptorsNamespaces>$(InterceptorsNamespaces);Microsoft.AspNetCore.Http.Validation.Generated</InterceptorsNamespaces>' to your project. [/tmp/benchmarks-agent/benchmarks-server-1/iaulnbd3.afr/src/OrchardCore.Modules/OrchardCore.OpenId/OrchardCore.OpenId.csproj::TargetFramework=net10.0]

https://github.com/OrchardCMS/OrchardCore/pull/17685/files

[captainsafia]

We need to update the Web.SDK to insert this build property in on behalf of the user like we do for RDG.

[kevinchalet]

Copied from OrchardCMS/OrchardCore#17685 (comment):

@sebastienros Extra thought I had after our convo yesterday: the generator only intercepts "AddValidation" calls so there is is a chance that there might be one in this source code that it is greedily discovering.

@captainsafia is likely right about the root cause of that issue: the detection logic used in FindAddValidation doesn't properly check that the AddValidation() extension belongs to the expected static class:

aspnetcore/src/Http/Http.Extensions/gen/Microsoft.AspNetCore.Http.ValidationsGenerator/Parsers/ValidationsGenerator.AddValidation.cs

Lines 14 to 23 in d24486f

	internal bool FindAddValidation(SyntaxNode syntaxNode, CancellationToken cancellationToken)
	{
	if (syntaxNode is InvocationExpressionSyntax
	&& syntaxNode.TryGetMapMethodName(out var method)
	&& method == "AddValidation")
	{
	return true;
	}
	return false;
	}

[captainsafia]

@kevinchalet Yep -- we need to harden the check we do here the same way we do it in the OpenAPI XML doc generator.

aspnetcore/src/OpenApi/gen/XmlCommentGenerator.Parser.cs

Lines 127 to 137 in d24486f

	var invocationExpression = (InvocationExpressionSyntax)context.Node;
	// Soft check to validate that the method is from the OpenApiServiceCollectionExtensions class
	// in the Microsoft.AspNetCore.OpenApi assembly.
	var symbol = context.SemanticModel.GetSymbolInfo(invocationExpression, cancellationToken).Symbol;
	if (symbol is not IMethodSymbol methodSymbol
	|| methodSymbol.ContainingType.Name != "OpenApiServiceCollectionExtensions"
	|| methodSymbol.ContainingAssembly.Name != "Microsoft.AspNetCore.OpenApi")
	{
	return new(AddOpenApiOverloadVariant.Unknown, invocationExpression, null);
	}

Edit: One thing to note is that we can't do it in the codepath referenced above since the syntax provider doesn't have access to the symbols. We'll have to do it at a later stage in the pipeline but it should be possible.

[captainsafia]

Opened a PR for this in #61193.

[marcpopMSFT]

@sebastienros Were you able to find a workaround for OrchardCore? I'm trying to fix the perf test that uses that project. I've tried adding the following to OrchardCore.OpenId.csproj but then get this error instead:
<InterceptorsNamespaces>$(InterceptorsNamespaces);Microsoft.AspNetCore.Http.Validation.Generated</InterceptorsNamespaces> <InterceptorsPreventNamespaces>$(InterceptorsPreventNamespaces);OpenIddict</InterceptorsPreventNamespaces>

Cannot intercept method 'OpenIddictValidationExtensions.AddValidation(OpenIddictBuilder, Action)' with interceptor 'GeneratedServiceCollectionExtensions.AddValidation(IServiceCollection, Action?)' because the signatures do not match.