Node.js processes don't quit after stopping debugging

[chesteryang]

Please refer to dotnet/vscode-csharp#2387 for details.

If there has been a fix, let me know how.

[bharney]

Until then I guess you can always kill the processes manually taskkill /f /im node.exe

[chesteryang]

@bharney Thanks, I am using windows so I can use task manager to kill a process. Another workaround is to launch app in external command line window and after stopping debug, as this window is still on, I can use ctrl+c to terminate it.
But this is indeed a bug. If I use Visual Studio 2017, those node processes will be killed after stopping debug. Only Visual Studio Code failed to do so.

[remcoros]

It's not specific to just vscode and/or debugging.

I start my app using "dotnet run".

When closing that console (or hit Ctrl+C), the webserver stops running, but both the .NET process and node.exe process stay running as zombie processes:

[mkArtakMSFT]

Thanks for contacting us.
@SteveSandersonMS, is there anything we can do here?
Looks like the way we start the npm process already passes the parent process id, but for some reason it doesn't end, when the parent ends: https://github.com/aspnet/JavaScriptServices/blob/892d3c04202c67fc06fe89ff3580f6e99612b55b/src/Microsoft.AspNetCore.NodeServices/HostingModels/OutOfProcessNodeInstance.cs#L232

[SteveSandersonMS]

I agree it would be good if we could find a way to do this automatically. I don't know the correct way to launch child process such that they (and all transitive descendant processes) will die automatically if the root process dies, but if there is a way to do that, I expect we'd accept a PR to use that technique.

[pakrym]

You can use job objects. We do this for IIS Express tests (https://github.com/aspnet/AspNetCore/blob/3477daf3c4f530dff80f197e0642cb39a26fb07b/src/Servers/IIS/IntegrationTesting.IIS/src/ProcessTracker.cs)

[loop-evgeny]

This happens for me in VS 2017 Pro 15.9.9 and VS 2019 Preview 4.2. When I start an ASP.NET Core 2.1 or 2.2 React app from VS (with debugging) and stop debugging the node.exe processes remain. If I run outside of VS using dotnet run and kill that with Control+C the node.exe processes exit.