Should MapShortCircuit matches for all methods or only GET?

[Kahbazi]

I just noticed that MapShortCircuit API doc is different than its behavior. The docs says that it matches the GET request

aspnetcore/src/Http/Routing/src/ShortCircuit/RouteShortCircuitEndpointRouteBuilderExtensions.cs

Line 16 in f62f123

/// Adds a <see cref="RouteEndpoint"/> to the <see cref="IEndpointRouteBuilder"/> that matches HTTP GET requests

but the implementation matches all the methods

aspnetcore/src/Http/Routing/src/ShortCircuit/RouteShortCircuitEndpointRouteBuilderExtensions.cs

Line 37 in f62f123

group.Map(route, _shortCircuitDelegate)

I can't remember which one was the requirement but one of them has to be changed!

@Tratcher

[mitchdenny]

#46071

Original discussion appears to be silent. That said I think it makes sense to cover all HTTP methods rather than just GET when we consider the original goals of the extension.

[davidfowl]

I agree with @mitchdenny

[Tratcher]

The design was intended to cover all methods, but you could constrain it by adding method metadata. (Hmm, there's no WithMethods extension to add constraints, everything else assumes you do methods first?). app.MapGet(pattern, delegate).ShortCircuit(); also works.