Missing x86 vs x64 qualifier in add/remove programs for ASP.NET Core shared framework

[nguerrera]

Describe the bug

ASP.NET Core Shared Framework add/remove programs entry doesn't differentiate x86 and x64 and appears like a duplicate.

To Reproduce

I saw this after Microsoft Update pushed new versions to my machine. The prior versions were from Visual Studio and hidden from add/remove programs. I have not verified, but I suspect you can repro this on any machine by installing both x64 and x86 ASP.NET Core shared frameworks

Exceptions (if any)

Further technical details

.NET SDK (reflecting any global.json):
 Version:   5.0.300-preview.21258.4
 Commit:    e659912dfb

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.19043
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\5.0.300-preview.21258.4\

Host (useful for support):
  Version: 5.0.6
  Commit:  478b2f8c0e

.NET SDKs installed:
  5.0.300-preview.21258.4 [C:\Program Files\dotnet\sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.All 2.1.28 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.1.28 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.1.15 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 5.0.5 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 5.0.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 2.1.28 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.1.15 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 5.0.5 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 5.0.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 3.1.15 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 5.0.5 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 5.0.6 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

To install additional .NET runtimes or SDKs:
  https://aka.ms/dotnet-download

[Pilchie]

Tagging @wtgodbe

[wtgodbe]

Thanks for the report - looks like it should be as simple as updating

aspnetcore/src/Installers/Windows/SharedFrameworkBundle/SharedFrameworkBundle.wixproj

Lines 67 to 69 in fdabaf0

	<BundleNameShort>Microsoft ASP.NET Core $(PackageBrandingVersion)</BundleNameShort>
	<BundleNameSub>Shared Framework</BundleNameSub>
	<BundleName>$(BundleNameShort) - $(BundleNameSub)</BundleName>

to include Platform. I'll spin up PRs & validate

[wtgodbe]

Actually, maybe this is intentional? BundleNameFull is just BundleName + Platform, which implies leaving Platform out of BundleName was on purpose:

aspnetcore/src/Installers/Windows/SharedFrameworkBundle/SharedFrameworkBundle.wixproj

Lines 67 to 70 in fdabaf0

	<BundleNameShort>Microsoft ASP.NET Core $(PackageBrandingVersion)</BundleNameShort>
	<BundleNameSub>Shared Framework</BundleNameSub>
	<BundleName>$(BundleNameShort) - $(BundleNameSub)</BundleName>
	<BundleNameFull>$(BundleName) ($(Platform))</BundleNameFull>

@joeloff any harm in including Platform in BundleName and having it be identical to BundleNameFull?

[wtgodbe]

For what it's worth, dotnet/runtime does include Platform in the bundle name that gets displayed in add/remove programs

[joeloff]

Yeah, this dates back to 2.0. The hosting bundle didn't have platform information in the name and I suspect we maybe copied/reused some properties for the shared framework bundle. Would be good to fix in the standalone fx bundles

[wtgodbe]

PR: #32778. I'll put up backport PRs once I've validated it does what I expect

[wtgodbe]

#32968
#32969