Check Web APIs returning ActionResult with status code 2xx

[sshanzel]

Describe the problem you are trying to solve

ActionResult accepts a generic parameter but doesn't enforce strict-typing (related issue).
But as what we have discussed here, it is ideal to improve the Analyzers instead of making the changes with the ControllerBase.

Describe suggestions on how to achieve the rule

I am literally new with Analyzers (like a few hours ago) but it would be awesome if we will be able to check the MethodDeclarationSyntax of a ReturnStatementSyntax to see if the content type of the returned OkObjectResult matches the identified generic parameter from the method itself (please do correct me if I'm wrong on what I have initially thought for the solution).

I suggest displaying red curly underlines to notify the developer of the mismatch.

Additional context

Even though I literally haven't tried making a single rule, I did a few moments ago but failed miserably (link to the repo - actual rule). Hence, went here to seek help.

[sshanzel]

I'm not really sure yet how can I infer the type from OkObjectResult returned value, being unable to have the correct type checking at:
https://github.com/sshanzel/RoslynAnalyzer-Proposal/blob/a9b45300a504e7878b644cc5a08d33eddd1b6e40/ProducesResponseTypeAnalyzer/ProducesResponseTypeAnalyzer/ProducesResponseTypeAnalyzerAnalyzer.cs#L71

[davidfowl]

It would go here btw https://github.com/dotnet/aspnetcore/tree/master/src/Analyzers/Analyzers/src

[sshanzel]

It would go here btw https://github.com/dotnet/aspnetcore/tree/master/src/Analyzers/Analyzers/src

Thanks a lot for letting me know, I'd be sure to check this one out!

[Evangelink]

Does it mean this ticket should be moved across to aspnetcore repo? If not I can have a look at the implementation but with my poor web experience I'd be happy to have someone providing "test" cases of when to report and when not to.

[Evangelink]

Ping @mavasani and @davidfowl

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.