Skip to content

Commit

Permalink
Flow FullAssemblySigningSupported for source-build to repo tasks (#47421
Browse files Browse the repository at this point in the history
)

This property is being added to arcade via
dotnet/arcade#12749 and
dotnet/arcade#12940

Once this property is added to arcade, it flows correctly to the main
aspnetcore build, but not to the build for repo tasks. The repo tasks
still need this, otherwise they end up using full signing.

Fix that by manually passing the property along (using env var) when
building the repo tasks.
  • Loading branch information
omajid authored Mar 30, 2023
1 parent dca3917 commit f06a603
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions eng/SourceBuild.props
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@
<_AdditionalRepoTaskBuildArgs Condition="'$(DotNetRuntimeSourceFeedKey)' != ''" >$(_AdditionalRepoTaskBuildArgs) --runtimesourcefeedkey $(DotNetRuntimeSourceFeedKey)</_AdditionalRepoTaskBuildArgs>
</PropertyGroup>

<ItemGroup>
<!-- We need to flow FullAssemblySigningSupported even when building repo tasks because they use full signing -->
<InnerBuildEnv Condition="'$(FullAssemblySigningSupported)' != ''" Include="FullAssemblySigningSupported=$(FullAssemblySigningSupported)" />
</ItemGroup>

<!-- Call the build.sh script to build the repo tasks. Set IgnoreStandardErrorWarningFormat
to true. This avoids fatal errors, because in internal builds there are usually a few failed installation
attempts as the install script walks through potential locations for a runtime.
Expand Down

0 comments on commit f06a603

Please sign in to comment.