Skip to content

Commit

Permalink
Skip H2Spec 6.9.2/2 (#58430)
Browse files Browse the repository at this point in the history
  • Loading branch information
BrennanConroy authored Oct 15, 2024
1 parent 298c0ad commit e25c5ac
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions src/Servers/Kestrel/test/Interop.FunctionalTests/H2SpecTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,11 @@ public static TheoryData<H2SpecTestCase> H2SpecTestCases
get
{
var dataset = new TheoryData<H2SpecTestCase>();
// { Test name, Skip Reason }
var toSkip = new Dictionary<string, string>
{
{ "http2/6.9.2/2", "https://github.com/dotnet/aspnetcore/issues/47452" }
};

var testCases = H2SpecCommands.EnumerateTestCases();

Expand All @@ -77,11 +82,18 @@ public static TheoryData<H2SpecTestCase> H2SpecTestCases

foreach (var testcase in testCases)
{
string skip = null;
if (toSkip.TryGetValue(testcase.Item1, out var skipReason))
{
skip = skipReason;
}

dataset.Add(new H2SpecTestCase
{
Id = testcase.Item1,
Description = testcase.Item2,
Https = false,
Skip = skip,
});

// https://github.com/dotnet/aspnetcore/issues/11301 We should use Skip but it's broken at the moment.
Expand All @@ -92,6 +104,7 @@ public static TheoryData<H2SpecTestCase> H2SpecTestCases
Id = testcase.Item1,
Description = testcase.Item2,
Https = true,
Skip = skip,
});
}
}
Expand Down

0 comments on commit e25c5ac

Please sign in to comment.