Mark IgnitorSample as non-packable (#27597)

- also align TestTasks with other packable / non-shipping projects in same boat nit: s/internal-use/internal use/
dotnet · Nov 7, 2020 · 5a2bb94 · 5a2bb94
1 parent 0271083
commit 5a2bb94
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 5 deletions.
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -130,7 +130,7 @@
     <IsTargetingPackBuilding Condition=" '$(IsTargetingPackBuilding)' == '' ">true</IsTargetingPackBuilding>
 
     <!--
-      Archives and installers using this prefix are intended for internal-use only.
+      Archives and installers using this prefix are intended for internal use only.
       For example, this .zip is used to handoff bits to partner teams who then incorporate our shared frameworks
       into their own installers.
     -->

diff --git a/src/Components/Samples/IgnitorSample/IgnitorSample.csproj b/src/Components/Samples/IgnitorSample/IgnitorSample.csproj
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
-    <IsShippingPackage>false</IsShippingPackage>
+    <IsPackable>false</IsPackable>
     <Nullable>enable</Nullable>
     <OutputType>Exe</OutputType>
   </PropertyGroup>

diff --git a/...sting/Server.IntegrationTesting/src/Microsoft.AspNetCore.Server.IntegrationTesting.csproj b/...sting/Server.IntegrationTesting/src/Microsoft.AspNetCore.Server.IntegrationTesting.csproj
@@ -6,9 +6,9 @@
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <PackageTags>aspnetcore;testing</PackageTags>
     <IsTestAssetProject>true</IsTestAssetProject>
-    <!-- This is used as a package by aspnet benchmarking infrastructure. It is meant for internal-use only. -->
-    <IsShippingPackage>false</IsShippingPackage>
+    <!-- This is used as a package by ASP.NET benchmarking infrastructure. It is meant for internal use only. -->
     <IsPackable>true</IsPackable>
+    <IsShippingPackage>false</IsShippingPackage>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/Servers/IIS/IIS/test/testassets/TestTasks/TestTasks.csproj b/src/Servers/IIS/IIS/test/testassets/TestTasks/TestTasks.csproj
@@ -4,7 +4,13 @@
     <OutputType>Exe</OutputType>
     <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
     <RuntimeIdentifiers>win-x64;linux-x64;osx-x64</RuntimeIdentifiers>
+
+    <!--
+      This is used as a package by ASP.NET benchmarking infrastructure. It is meant for internal use only. See also
+      the Microsoft.AspNetCore.Server.IntegrationTesting and ...IntegrationTesting.IIS projects.
+    -->
     <IsPackable>true</IsPackable>
+    <IsShippingPackage>false</IsShippingPackage>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/.../IIS/IntegrationTesting.IIS/src/Microsoft.AspNetCore.Server.IntegrationTesting.IIS.csproj b/.../IIS/IntegrationTesting.IIS/src/Microsoft.AspNetCore.Server.IntegrationTesting.IIS.csproj
@@ -9,7 +9,7 @@
     <DisableFastUpToDateCheck>True</DisableFastUpToDateCheck>
     <AspNetCoreModuleOutOfProcessVersion>2.0.0</AspNetCoreModuleOutOfProcessVersion>
     <IsTestAssetProject>true</IsTestAssetProject>
-    <!-- This is used as a package by aspnet benchmarking infrastructure. It is meant for internal-use only. -->
+    <!-- This is used as a package by ASP.NET benchmarking infrastructure. It is meant for internal use only. -->
     <IsPackable>true</IsPackable>
     <IsShippingPackage>false</IsShippingPackage>
     <!--