Skip to content

Fully qualify OutputPath for PublishingContext #9351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025
Merged

Fully qualify OutputPath for PublishingContext #9351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Aspire.Hosting/Publishing/Publisher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public Task PublishAsync(DistributedApplicationModel model, CancellationToken ca
);
}

var context = new PublishingContext(model, executionContext, serviceProvider, logger, cancellationToken, options.Value.OutputPath);
var context = new PublishingContext(model, executionContext, serviceProvider, logger, cancellationToken, Path.GetFullPath(options.Value.OutputPath));
Copy link
Member

@davidfowl davidfowl May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, relative to what? CWD? I think this is right.

Copy link
Member Author

@captainsafia captainsafia May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep -- it uses CWD as the base AFAIK. I'll remember to update the tests to check for this as a tack on to a future PR.

return context.WriteModelAsync(model);
}
}
3 changes: 2 additions & 1 deletion tests/Aspire.Hosting.Tests/PublishingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ public void PublishCallsPublishingCallback()
Assert.True(context.CancellationToken.CanBeCanceled);
Assert.Equal(DistributedApplicationOperation.Publish, context.ExecutionContext.Operation);
Assert.Equal("default", context.ExecutionContext.PublisherName);
Assert.True(Path.IsPathFullyQualified(context.OutputPath));
publishedCalled = true;
return Task.CompletedTask;
});
Expand All @@ -32,4 +33,4 @@ public void PublishCallsPublishingCallback()

Assert.True(publishedCalled, "Publishing callback was not called.");
}
}
}