Skip to content

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Apr 14, 2025

Description

I noticed that info in logs had an explicit black background which you could see when hovering over a row. info would have a black background that would be different to the rest of the hovered row.

The fix is to add the idea of a default background color and explicit background that matches is skipped (i.e. black on black is converted to transparent)

After:
image

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@adamint adamint merged commit 0e84a68 into main Apr 14, 2025
174 checks passed
@adamint adamint deleted the jamesnk/consolelogs-defaultbackground branch April 14, 2025 15:03
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants