Move shared test utilities from Aspire.Components.Common.Tests to Aspire.TestUtilities #8279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussKie
requested review from
ReubenBond,
eerhardt,
mitchdenny and
radical
as code owners
Contributor
There was a problem hiding this comment.
Copilot reviewed 36 out of 56 changed files in this pull request and generated no comments.
Files not reviewed (20)
- Aspire.sln: Language not supported
- tests/Aspire.Azure.AI.OpenAI.Tests/Aspire.Azure.AI.OpenAI.Tests.csproj: Language not supported
- tests/Aspire.Azure.Data.Tables.Tests/Aspire.Azure.Data.Tables.Tests.csproj: Language not supported
- tests/Aspire.Azure.Messaging.EventHubs.Tests/Aspire.Azure.Messaging.EventHubs.Tests.csproj: Language not supported
- tests/Aspire.Azure.Messaging.ServiceBus.Tests/Aspire.Azure.Messaging.ServiceBus.Tests.csproj: Language not supported
- tests/Aspire.Azure.Messaging.WebPubSub.Tests/Aspire.Azure.Messaging.WebPubSub.Tests.csproj: Language not supported
- tests/Aspire.Azure.Search.Documents.Tests/Aspire.Azure.Search.Documents.Tests.csproj: Language not supported
- tests/Aspire.Azure.Security.KeyVault.Tests/Aspire.Azure.Security.KeyVault.Tests.csproj: Language not supported
- tests/Aspire.Azure.Storage.Blobs.Tests/Aspire.Azure.Storage.Blobs.Tests.csproj: Language not supported
- tests/Aspire.Azure.Storage.Queues.Tests/Aspire.Azure.Storage.Queues.Tests.csproj: Language not supported
- tests/Aspire.Cli.Tests/Aspire.Cli.Tests.csproj: Language not supported
- tests/Aspire.Components.Common.Tests/Aspire.Components.Common.Tests.csproj: Language not supported
- tests/Aspire.Confluent.Kafka.Tests/Aspire.Confluent.Kafka.Tests.csproj: Language not supported
- tests/Aspire.Dashboard.Tests/Aspire.Dashboard.Tests.csproj: Language not supported
- tests/Aspire.Elastic.Clients.Elasticsearch.Tests/Aspire.Elastic.Clients.Elasticsearch.Tests.csproj: Language not supported
- tests/Aspire.Hosting.Containers.Tests/Aspire.Hosting.Containers.Tests.csproj: Language not supported
- tests/Aspire.Hosting.Testing.Tests/Aspire.Hosting.Testing.Tests.csproj: Language not supported
- tests/Aspire.Hosting.Tests/Aspire.Hosting.Tests.csproj: Language not supported
- tests/Aspire.Keycloak.Authentication.Tests/Aspire.Keycloak.Authentication.Tests.csproj: Language not supported
- tests/Aspire.Microsoft.Azure.Cosmos.Tests/Aspire.Microsoft.Azure.Cosmos.Tests.csproj: Language not supported
github-actions
bot
added
the
area-integrations
RussKie
force-pushed
the
chore_testutils
branch
3 times, most recently
from
1fda196 to
4977698
Compare
radical
reviewed
Mar 25, 2025
...onfigurationSchemaGenerator/RuntimeSource/Configuration.Binder/Parser/ConfigurationBinder.cs
Show resolved
Hide resolved
tests/Aspire.Microsoft.Azure.Cosmos.Tests/Aspire.Microsoft.Azure.Cosmos.Tests.csproj
Outdated
Show resolved
Hide resolved
tests/Aspire.Microsoft.Data.SqlClient.Tests/Aspire.Microsoft.Data.SqlClient.Tests.csproj
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Mar 25, 2025
src/Vendoring/OpenTelemetry.Instrumentation.ConfluentKafka/ConfluentKafkaCommon.cs
Show resolved
Hide resolved
RussKie
force-pushed
the
chore_testutils
branch
4 times, most recently
from
c1d24c0 to
5dff61b
Compare
RussKie
force-pushed
the
chore_testutils
branch
from
5dff61b to
da7618c
Compare
Member
|
Can you run the azdo pipeline also for this? |
radical
reviewed
Mar 26, 2025
radical
reviewed
Mar 26, 2025
radical
reviewed
Mar 26, 2025
RussKie
force-pushed
the
chore_testutils
branch
3 times, most recently
from
a19f352 to
1662bb3
Compare
radical
reviewed
Mar 27, 2025
…ire.TestUtilities
RussKie
force-pushed
the
chore_testutils
branch
from
1662bb3 to
9da187e
Compare
joperezr
reviewed
Apr 4, 2025
| <ItemGroup> | ||
| <PackageReference Include="AspNetCore.HealthChecks.SqlServer" /> | ||
| <PackageReference Include="Microsoft.Data.SqlClient" /> | ||
| <PackageReference Include="Microsoft.DotNet.RemoteExecutor" /> |
Member
There was a problem hiding this comment.
@RussKie Assuming this was unintentional and likely a find/replace or similar issue? We need to undo this as it is obviously not okay to depend on this from the product code.
Contributor
Author
There was a problem hiding this comment.
Thank you for noticing; this doesn't look correct.
18 tasks
RussKie
added a commit
to RussKie/aspire
that referenced
this pull request
Apr 7, 2025
RussKie
added a commit
that referenced
this pull request
Apr 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.