Support Azure SqlServer role assignments on app specific managed identity #8226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tity Adding role assignment support for PostgreSQL following the pattern set in dotnet#8140 Fix dotnet#6161
eerhardt
requested review from
captainsafia,
Copilot,
davidfowl and
sebastienros
github-actions
bot
added
the
area-integrations
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Azure SQL Server role assignments on app-specific managed identities by extending existing resource patterns and updating tests accordingly.
- Introduces a new NameOutputReference and AddRoleAssignments method in AzureSqlServerResource.
- Adjusts the AzureSqlExtensions logic to generate role assignments and outputs the server name.
- Updates tests to verify the new role assignment outputs in generated Bicep manifests.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Aspire.Hosting.Azure.Sql/AzureSqlServerResource.cs | Added role assignment support and a NameOutputReference property for exporting the server name. |
| src/Aspire.Hosting.Azure.Sql/AzureSqlExtensions.cs | Updated resource creation logic and annotation to support role assignments. |
| tests/Aspire.Hosting.Azure.Tests/* | Extended tests to check for server name outputs in the Bicep manifests. |
Comments suppressed due to low confidence (1)
src/Aspire.Hosting.Azure.Sql/AzureSqlServerResource.cs:111
- [nitpick] The variable name 'postgres' is misleading as it represents an SQL Server resource. Consider renaming it to 'sqlServer' for improved clarity.
var postgres = (SqlServer)AddAsExistingResource(infra);
davidfowl
reviewed
Mar 21, 2025
| var resource = new AzureSqlServerResource(name, configureInfrastructure); | ||
| var azureSqlServer = builder.AddResource(resource); | ||
| var azureSqlServer = builder.AddResource(resource) | ||
| .WithAnnotation(new DefaultRoleAssignmentsAnnotation(new HashSet<RoleDefinition>())); |
Member
There was a problem hiding this comment.
Suggested change
| .WithAnnotation(new DefaultRoleAssignmentsAnnotation(new HashSet<RoleDefinition>())); | |
| .WithAnnotation(new DefaultRoleAssignmentsAnnotation([])); |
Member
Author
There was a problem hiding this comment.
Can't because of [API Proposal]: Allow collections expression for other collections (dotnet/runtime#108457). The parameter is of type IReadOnlySet which doesn't support collection expressions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding role assignment support for PostgreSQL following the pattern set in #8140
Fix #6161
Checklist