Optimize required unix file modes #7781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienros
commented
Feb 26, 2025
| @@ -1206,6 +1188,8 @@ private async Task CreateContainerAsync(AppResource cr, ILogger resourceLogger, | |||
| spec.Ports = BuildContainerPorts(cr); | |||
| } | |||
|
|
|||
| spec.VolumeMounts = BuildBindMounts(modelContainerResource); | |||
There was a problem hiding this comment.
The idea is to be able to add container mount annotations during the AftertEndpointAllocated. The same way endpoints are built in CreateContainerAsync. Otherwise we can't create file mounts with deterministic names based on the file content (for persistent containers).
NB: In the case of MySql/PgSql the target ports are currently used, which are static. Resolution is done thought host name since it's docker to docker communication. This means that at least this part of the configuration in invariant across restarts.
There was a problem hiding this comment.
FYI - @mitchdenny @karolz-ms @danegsta
eerhardt
reviewed
Feb 27, 2025
| @@ -1206,6 +1188,8 @@ private async Task CreateContainerAsync(AppResource cr, ILogger resourceLogger, | |||
| spec.Ports = BuildContainerPorts(cr); | |||
| } | |||
|
|
|||
| spec.VolumeMounts = BuildBindMounts(modelContainerResource); | |||
There was a problem hiding this comment.
FYI - @mitchdenny @karolz-ms @danegsta
tests/Aspire.Hosting.SqlServer.Tests/SqlServerFunctionalTests.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Feb 27, 2025
eerhardt
reviewed
Feb 27, 2025
davidfowl
reviewed
Feb 27, 2025
eerhardt
approved these changes
Feb 27, 2025
eerhardt
reviewed
Feb 27, 2025
| @@ -101,25 +101,15 @@ public static IResourceBuilder<SqlServerServerResource> WithDataVolume(this IRes | |||
| /// <param name="source">The source directory on the host to mount into the container.</param> | |||
| /// <param name="isReadOnly">A flag that indicates if this is a read-only mount.</param> | |||
| /// <returns>The <see cref="IResourceBuilder{T}"/>.</returns> | |||
| /// <remarks> | |||
| /// The container starts up as non-root and the <paramref name="source"/> directory must be readable by the user that the container runs as. | |||
There was a problem hiding this comment.
Suggested change
| /// The container starts up as non-root and the <paramref name="source"/> directory must be readable by the user that the container runs as. | |
| /// The container starts up as non-root and the <paramref name="source"/> directory must be readable and writeable by the user that the container runs as. |
danmoseley
pushed a commit
that referenced
this pull request
Feb 28, 2025
github-actions
bot
added
the
area-integrations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AfterEndpointsAllocatedEvent.Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):