Rebuild Azure Functions project before test run #7748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainsafia
force-pushed
the
cs/gha-funcs-fix
branch
10 times, most recently
from
366f1f7 to
26b35a6
Compare
captainsafia
force-pushed
the
cs/gha-funcs-fix
branch
from
26b35a6 to
6750b76
Compare
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
.github/workflows/tests.yml:191
- Verify that the condition 'matrix.name == "Playground"' correctly identifies the Azure Functions project. If the matrix contains multiple project types, consider a more robust condition to prevent unintended builds.
+ if: matrix.name == 'Playground'
tests/Aspire.Playground.Tests/ProjectSpecificTests.cs:59
- Confirm that the removal of the ActiveIssue attribute is intentional and that the test now reliably passes. Remove the attribute only after ensuring the underlying issue has been fully resolved.
- [ActiveIssue("https://github.com/dotnet/aspire/issues/7437")]
davidfowl
reviewed
Feb 25, 2025
eerhardt
reviewed
Feb 25, 2025
|
Can we add the explanation of the problem, and the workaround being used here to the PR description? I'm guessing that it would be essentially what you said in #7437 (comment) . |
eerhardt
approved these changes
Feb 25, 2025
github-actions
bot
added
the
area-integrations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #7437 by rebuilding the Functions project again after the build of test projects to force resolution of trigger metadata correctly before the Functions test runs.
This is a workaround for Azure/azure-functions-dotnet-worker#2969.