-
Notifications
You must be signed in to change notification settings - Fork 760
Add commands to console logs page #6819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Feels good to use. cc @davidfowl @DamianEdwards @leslierichardson95 in case you have any UI feedback. |
|
This looks really good to me |
|
I wonder if some users will expect this to stop the logs, rather than the resource, which could be annoying or even dangerous (in ACA for example). Some ideas that might help with this:
|
|
The button icons and text come from the resource commands. Right now they just say The buttons on the page could be removed and commands are only in a nested e.g. to stop a resource, you would go |
|
If we add log specific commands where would they go? |
|
In the example above? Resource commands |
|
Only if the user reads the tool tip. Having a button that stops a resource without any confirmation that might be mistaken to do something else seems like it could cause some undue problems. I'm thinking of the scenario where something is logging rapidly and the user wants to pause the logs to make it easier to read them, so they click the "stop" button thinking that's what it does. What about splitting that "toolbar" area such that all resource related stuff is on one side (combo box, commands) and all log related stuff is on the other side (status, download, future pause/resume/clear buttons). |
|
I don't see a good place to put command buttons on the left. If they were placed between the dropdown and status message it wouldn't look good because there can be a variable number of commands for a resource, and the status message location would jump around. Edit: Maybe if the status was moved to the right then it could work. |
| AdditionalAttributes = new Dictionary<string, object> | ||
| { | ||
| { "data-action", "download" }, | ||
| { "data-resource", PageViewModel.SelectedResource?.Name ?? string.Empty } | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamint I believe these were left over from earlier iterations of logs download. I removed them and everything still seems to work
| } | ||
| }, | ||
| displayDescription: null, | ||
| displayDescription: "Start resource", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any ideas on how we could localize these? Options including having the server send all translated values, or sending a known key value that's then looked up in the dashboard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there is any plan for this kind of text to be localizable. Like state text, the API for adding commands just takes one string. That would need to change, and then I guess the server would need to send the frontend lang in a cookie or query string.



Description
Fixes #6626
Demo:
Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):Microsoft Reviewers: Open in CodeFlow