Skip to content

Conversation

radical
Copy link
Member

@radical radical commented Oct 21, 2024

Description

Tests for main are run on the public pipeline, and are not needed for the internal one where we essentially build the packages to be published.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@radical radical requested review from RussKie, eerhardt and joperezr and removed request for RussKie October 21, 2024 17:56
@radical
Copy link
Member Author

radical commented Oct 21, 2024

@radical radical added the area-engineering-systems infrastructure helix infra engineering repo stuff label Oct 21, 2024
@radical
Copy link
Member Author

radical commented Oct 23, 2024

@joperezr this one is ready for review.

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@joperezr
Copy link
Member

Merging and backporting this to release/9.0 as it is needed for the internal builds too. Thanks @radical!

@joperezr joperezr merged commit f3a410d into dotnet:main Oct 23, 2024
9 checks passed
@radical radical deleted the no-tests-internal branch October 23, 2024 21:29
@joperezr
Copy link
Member

/backport to release/9.0

Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/aspire/actions/runs/11488497385

@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-engineering-systems infrastructure helix infra engineering repo stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants