Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ResourceReadyEvent to avoid blocking startup importing redis databases #6308

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

davidfowl
Copy link
Member

@davidfowl davidfowl commented Oct 15, 2024

Replaces #6141

Description

This pull request focuses on ensuring that all endpoints are allocated before attempting to import databases in Redis-related operations. It introduces a mechanism to wait for the allocation of endpoints and modifies the test to verify this behavior.

Improvements to Redis resource handling:

Test updates:

Fixes #6136
Fixes #6099

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@davidfowl davidfowl marked this pull request as ready for review October 15, 2024 07:39
@davidfowl davidfowl added area-integrations Issues pertaining to Aspire Integrations packages redis Issues related to redis integrations labels Oct 15, 2024
@davidfowl davidfowl added this to the 9.0 milestone Oct 15, 2024
@mitchdenny
Copy link
Member

Good technique for jumping across to a non-blocking event. LGTM.

@davidfowl davidfowl enabled auto-merge (squash) October 15, 2024 08:05
@davidfowl davidfowl merged commit ac08fcf into main Oct 15, 2024
9 checks passed
@davidfowl davidfowl deleted the davidfowl/fix-redis-hang branch October 15, 2024 08:53
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages redis Issues related to redis integrations
Projects
None yet
3 participants