Skip to content

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Oct 10, 2024

Description

Update FluentUI.

Workaround for menu can't be removed as the fix in FluentUI isn't correct. Hopefully it can be removed next version. Maybe wait for the next FluentUI version as this one doesn't have changes we need.

I think we stick with the current version for 9.0.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@JamesNK JamesNK added area-dashboard NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) labels Oct 10, 2024
@JamesNK JamesNK requested review from drewnoakes and adamint October 10, 2024 10:26
@JamesNK JamesNK force-pushed the jamesnk/fluentui-20241010 branch from 4841b20 to 78e9167 Compare October 29, 2024 03:12
@JamesNK JamesNK removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Oct 29, 2024
@JamesNK
Copy link
Member Author

JamesNK commented Oct 29, 2024

Ready for review

Copy link
Member

@mitchdenny mitchdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JamesNK JamesNK merged commit e4ee02e into main Nov 7, 2024
9 checks passed
@JamesNK JamesNK deleted the jamesnk/fluentui-20241010 branch November 7, 2024 01:45
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants