Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NuGet and Docker dependencies #5575

Merged
merged 5 commits into from
Sep 13, 2024
Merged

Conversation

joperezr
Copy link
Member

@joperezr joperezr commented Sep 6, 2024

Description

Updating dependencies from NuGet and Docker.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 6, 2024
@@ -7,6 +7,6 @@ internal static class ElasticsearchContainerImageTags
{
public const string Registry = "docker.io";
public const string Image = "library/elasticsearch";
public const string Tag = "8.15.0";
public const string Tag = "8.15.1";
Copy link
Member

@sebastienros sebastienros Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eerhardt @radical we need to update the feed, right? I can do it for this one the other updates if you say yes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, we need to update the registry. I was going to take care of it but if you're planning on doing it then that works for me too.

@sebastienros
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sebastienros
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be good to wait for the dashboard to confirm the new fluent UI versions.

@davidfowl
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@joperezr joperezr enabled auto-merge (squash) September 12, 2024 23:29
@joperezr joperezr merged commit 06e995e into dotnet:main Sep 13, 2024
11 checks passed
@joperezr
Copy link
Member Author

/backport to release/8.2

Copy link
Contributor

Started backporting to release/8.2: https://github.com/dotnet/aspire/actions/runs/10855903601

Copy link
Contributor

@joperezr backporting to release/8.2 failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Update NuGet and Docker dependencies
Using index info to reconstruct a base tree...
M	Directory.Packages.props
M	eng/Version.Details.xml
M	eng/Versions.props
Falling back to patching base and 3-way merge...
Auto-merging eng/Versions.props
CONFLICT (content): Merge conflict in eng/Versions.props
Auto-merging eng/Version.Details.xml
Auto-merging Directory.Packages.props
CONFLICT (content): Merge conflict in Directory.Packages.props
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Update NuGet and Docker dependencies
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

Copy link
Contributor

@joperezr an error occurred while backporting to release/8.2, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

@eerhardt
Copy link
Member

@joperezr - were you planning on backporting this change to release/8.2?

joperezr added a commit to joperezr/aspire that referenced this pull request Sep 19, 2024
* Update NuGet and Docker dependencies

* Update cgmanifest.json file

* Update ConfigurationSchema.json files

* Revert FluentUI updates as there were test failures here

---------

Co-authored-by: Sebastien Ros <sebastienros@gmail.com>
joperezr added a commit that referenced this pull request Sep 20, 2024
* Update NuGet and Docker dependencies

* Update cgmanifest.json file

* Update ConfigurationSchema.json files

* Revert FluentUI updates as there were test failures here

---------

Co-authored-by: Sebastien Ros <sebastienros@gmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants