Skip to content

use static for classes with all static members #5485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2024
Merged

use static for classes with all static members #5485

merged 1 commit into from
Sep 9, 2024

Conversation

SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Aug 29, 2024 •
edited by dotnet-policy-service bot
Loading

i assume there is not a reason these are instance and sealed instead of static?

only internal types

Microsoft Reviewers: Open in CodeFlow

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 29, 2024
@davidfowl davidfowl merged commit d8caaec into dotnet:main Sep 9, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sebastienros sebastienros sebastienros approved these changes

@radical radical Awaiting requested review from radical radical is a code owner

@eerhardt eerhardt Awaiting requested review from eerhardt eerhardt is a code owner

@ReubenBond ReubenBond Awaiting requested review from ReubenBond ReubenBond is a code owner

Assignees
No one assigned
Labels
area-service-discovery community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonCropp @sebastienros @davidfowl