-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persist dismissing the OTLP unsecured message bar #5465
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
commented
Aug 28, 2024
<Authorized> | ||
@if (_showUserProfileMenu) | ||
{ | ||
@if (_showUserProfileMenu) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only include AuthorizeView on the page if the user profile should be displayed (which means the auth mode needs to be a certain value).
This avoids the need to include various authz services in tests.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Open
3 tasks
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
drewnoakes
approved these changes
Aug 29, 2024
JamesNK
force-pushed
the
jamesnk/otlp-unsecured-messagebar-dismiss
branch
from
August 29, 2024 02:38
729a469
to
8cb94d0
Compare
JamesNK
commented
Aug 29, 2024
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Running the dashboard without OTLP auth will display a warning message bar. The message bar can be dismissed, but it reappears if the browser is refreshed.
It is annoying to repeatedly show the message to a user who has already seen the warning. They either have to close the message every time, or accept it is always visible.
This PR:
Note that the warning displayed in console logs on startup isn't impacted. It's always displayed.
Checklist
<remarks />
and<code />
elements on your triple slash comments?