-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AzureFunctionsEndToEnd with prototype implementation #5418
Conversation
A test should be added for this too, see #5316 for an example. |
I'm not sure we want to test this sample yet. This is part of bootstrapping the azure functions work. |
playground/AzureFunctionsEndToEnd/AzureFunctionsEndToEnd.ApiService/Program.cs
Show resolved
Hide resolved
playground/AzureFunctionsEndToEnd/AzureFunctionsEndToEnd.Functions/HostBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
playground/AzureFunctionsEndToEnd/AzureFunctionsEndToEnd.Functions/HostBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
{ | ||
services.AddOpenTelemetry() | ||
.UseFunctionsWorkerDefaults() | ||
.UseOtlpExporter(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come this is here and not in .AddServiceDefaults
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IHostBuilder vs IHostApplicationBuilder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AddServiceDefaults (called above) is also implemented in terms of IHostBuilder. It is in the HostBuilderExtensions.cs
file.
...reFunctionsEndToEnd/AzureFunctionsEndToEnd.Functions/AzureFunctionsEndToEnd.Functions.csproj
Show resolved
Hide resolved
playground/AzureFunctionsEndToEnd/AzureFunctionsEndToEnd.AppHost/Program.cs
Outdated
Show resolved
Hide resolved
src/Aspire.Hosting.Azure.Functions/AzureFunctionsProjectResourceExtensions.cs
Show resolved
Hide resolved
src/Aspire.Hosting.Azure.Functions/AzureFunctionsProjectResourceExtensions.cs
Show resolved
Hide resolved
src/Aspire.Hosting.Azure.Functions/AzureFunctionsProjectResourceExtensions.cs
Show resolved
Hide resolved
acfe6de
to
4bd935c
Compare
- We now scan all of the env variables and resolve references instead.
- Blob triggers require queues - There's a conflict with the connection string section
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
c98cc3d
to
bf8d90a
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
standing by ready for to do some testing on our internal project once this is released. Please feel free to reach out - dciborow. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Great to hear! I'll give the README another run through today to make sure we've captured all the limitations/setup instructions correctly. This is just the first part of the integration and there will be a few kinks to iron out. 😅 |
This PR introduces an AzureFunctionsEndToEnd sample application with prototype implementations of certain APIs:
IHostApplicationBuilder
have been reimplemented to targetHostBuilder
. This should be addressed on Azure Functions supportsIHostApplicationBuilder
.AzureFunctionsProjectResource
has been included that launches thefunc host
as an executable resource. This is a temporary implementation until we support modeling a Functions application as a project resource. These APIs are formally proposed in AddAzureFunctionsProjectResource
and extension methods #5412. Support for mocking the Functions app as a project resource can be added by updating the mock API definitions as follows:And making the following changes to
AzureFunctionsEndToEnd.Functions.csproj
:WithReference
implementation is implemented to support mapping resource strings as needed until Add support forIResourceWithAzureFunctionsConfig
interface #5408 is implemented.Microsoft Reviewers: Open in CodeFlow
Fixes #5412
Fixes #5408