[tests] Misc fixes for playground tests #5318
Conversation
… have TestEndpoints defined
…unsCleanly, even though the TestEndpoints for it are blocked
dotnet-issue-labeler
bot
added
the
area-integrations
radical
added
area-app-model
…uch one main test running
| @@ -27,6 +27,10 @@ | |||
| <ItemGroup> | |||
| <_TestRunCommandArguments Remove="@(_TestRunCommandArguments)" /> | |||
|
|
|||
| <_TestBlameArguments Remove="@(_TestBlameArguments)" /> | |||
There was a problem hiding this comment.
What's already in this item that need to be cleared?
There was a problem hiding this comment.
aspire/tests/helix/send-to-helix-inner.proj
Lines 66 to 70 in 79cdd06
There was a problem hiding this comment.
Why don't we want the defaults? Maybe adding a comment here could help.
There was a problem hiding this comment.
I had this on the commit message, which is not useful enough as it would get lost in the squashed commit: Remove the blame-hang-timeout for playground tests, as it is pretty much one main test running.
I'll add a comment with that expanded to:
Remove the blame-hang-timeout for playground tests, as it is pretty much one main test running - 'TestEndpointsReturnOk'. IOW, the blame-hang timeout would have to be at least as long as the full TestSession timeout.
Is that clearer? I'm in two minds now whether to instead use 20min blame-hang-timeout, which is the test session timeout, so it won't really serve any purpose. But if we add more tests and the session timeout goes up, then this hang timeout would become relevant.
| var appHostName = Path.GetFileNameWithoutExtension(asm); | ||
| if (appHostsWithTestEndpoints.Contains(appHostName)) |
There was a problem hiding this comment.
Can you add a comment why we are filtering these?
There was a problem hiding this comment.
I added a comment, and renamed the method so it is clearer.
Microsoft Reviewers: Open in CodeFlow