Skip to content

Conversation

Alirexaa
Copy link
Contributor

@Alirexaa Alirexaa commented Jul 21, 2024

Contributes to #3185
Contributes to #4294

Microsoft Reviewers: Open in CodeFlow

@Alirexaa Alirexaa requested a review from mitchdenny as a code owner July 21, 2024 21:16
@ghost ghost added the area-codeflow for labeling automated codeflow. intentionally a different color! label Jul 21, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 21, 2024
else
{
bindMountPath = Path.Combine(Path.GetTempPath(), Path.GetRandomFileName());
nats1.WithDataBindMount(bindMountPath);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious - WithDataBindMount is mounting to /var/lib/nats in the container. How is this test hitting that?

@radical radical added area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication testing ☑️ and removed area-codeflow for labeling automated codeflow. intentionally a different color! labels Jul 24, 2024
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again for the contributions!

@Alirexaa
Copy link
Contributor Author

LGTM. Thanks again for the contributions!

it's pleasure.

@eerhardt eerhardt merged commit 11e90df into dotnet:main Jul 29, 2024
9 checks passed
@Alirexaa Alirexaa deleted the nats-tests branch August 2, 2024 19:40
@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication community-contribution Indicates that the PR has been added by a community member testing ☑️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants